Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit and integration go-compatibility presubmits required #29582

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Make unit and integration go-compatibility presubmits required #29582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/jobs/kubernetes/sig-release/release-branch-jobs/1.24.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,7 +1412,6 @@ presubmits:
preset-dind-enabled: "true"
preset-service-account: "true"
name: pull-kubernetes-integration-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down Expand Up @@ -1590,7 +1589,6 @@ presubmits:
labels:
preset-service-account: "true"
name: pull-kubernetes-unit-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down
2 changes: 0 additions & 2 deletions config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,7 +1424,6 @@ presubmits:
preset-dind-enabled: "true"
preset-service-account: "true"
name: pull-kubernetes-integration-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down Expand Up @@ -1602,7 +1601,6 @@ presubmits:
labels:
preset-service-account: "true"
name: pull-kubernetes-unit-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down
2 changes: 0 additions & 2 deletions config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1453,7 +1453,6 @@ presubmits:
preset-dind-enabled: "true"
preset-service-account: "true"
name: pull-kubernetes-integration-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down Expand Up @@ -1629,7 +1628,6 @@ presubmits:
labels:
preset-service-account: "true"
name: pull-kubernetes-unit-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down
2 changes: 0 additions & 2 deletions config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,7 +1404,6 @@ presubmits:
preset-dind-enabled: "true"
preset-service-account: "true"
name: pull-kubernetes-integration-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down Expand Up @@ -1583,7 +1582,6 @@ presubmits:
labels:
preset-service-account: "true"
name: pull-kubernetes-unit-go-compatibility
optional: true
path_alias: k8s.io/kubernetes
spec:
containers:
Expand Down
3 changes: 1 addition & 2 deletions config/jobs/kubernetes/sig-testing/integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,13 @@ presubmits:
- name: pull-kubernetes-integration-go-compatibility
cluster: k8s-infra-prow-build
always_run: true
optional: true
decorate: true
skip_branches:
- .* # per-release job
annotations:
fork-per-release: "true"
fork-per-release-replacements: "GO_VERSION= -> GO_VERSION={{.GoVersion}}"
testgrid-dashboards: sig-testing-canaries
testgrid-create-test-group: 'true'
description: run with GO_VERSION set to the original go version used for this branch
path_alias: k8s.io/kubernetes
labels:
Expand Down
3 changes: 1 addition & 2 deletions config/jobs/kubernetes/sig-testing/make-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,14 @@ presubmits:
annotations:
fork-per-release: "true"
fork-per-release-replacements: "GO_VERSION= -> GO_VERSION={{.GoVersion}}"
testgrid-dashboards: sig-testing-canaries
testgrid-dashboards: presubmits-kubernetes-blocking
description: run with GO_VERSION set to the original go version used for this branch
decorate: true
cluster: k8s-infra-prow-build
skip_branches:
- .* # per-release job
labels:
preset-service-account: "true"
optional: true
always_run: true
path_alias: k8s.io/kubernetes
spec:
Expand Down
3 changes: 3 additions & 0 deletions config/testgrids/kubernetes/presubmits/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ dashboards:
- name: pull-kubernetes-integration
test_group_name: pull-kubernetes-integration
base_options: width=10
- name: pull-kubernetes-integration-go-compatibility
test_group_name: pull-kubernetes-integration-go-compatibility
base_options: width=10
- name: pull-kubernetes-verify
test_group_name: pull-kubernetes-verify
base_options: width=10
Expand Down