Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit and integration go-compatibility presubmits required #29582

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 23, 2023

The go-compatibility unit and integration presubmits run on release branches differ from the normal unit/integration presubmits only by the go version used

This moves them to required on the branches they run on (release-1.x branches only) so we guard against merging changes that break compatibility with the go version the minor version was originally released with.

cc @dims

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject labels May 23, 2023
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label May 23, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 23, 2023
@liggitt liggitt force-pushed the compatibility-required branch from 7d543db to 7796f72 Compare May 23, 2023 19:26
@liggitt liggitt force-pushed the compatibility-required branch from 7796f72 to 9082741 Compare May 26, 2023 13:15
@liggitt
Copy link
Member Author

liggitt commented May 26, 2023

/assign @aojea

@aojea
Copy link
Member

aojea commented May 26, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@aojea
Copy link
Member

aojea commented Jul 13, 2023

/lgtm

let's see what we break XD

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1572805 into kubernetes:master Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

@liggitt: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.24.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.24.yaml
  • key 1.25.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml
  • key 1.26.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
  • key 1.27.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml
  • key make-test.yaml using file config/jobs/kubernetes/sig-testing/make-test.yaml

In response to this:

The go-compatibility unit and integration presubmits run on release branches differ from the normal unit/integration presubmits only by the go version used

This moves them to required on the branches they run on (release-1.x branches only) so we guard against merging changes that break compatibility with the go version the minor version was originally released with.

cc @dims

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants