-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unit and integration go-compatibility presubmits required #29582
Make unit and integration go-compatibility presubmits required #29582
Conversation
7d543db
to
7796f72
Compare
7796f72
to
9082741
Compare
/assign @aojea |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm let's see what we break XD |
@liggitt: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The go-compatibility unit and integration presubmits run on release branches differ from the normal unit/integration presubmits only by the go version used
This moves them to required on the branches they run on (release-1.x branches only) so we guard against merging changes that break compatibility with the go version the minor version was originally released with.
cc @dims