Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pull-cloud-provider-azure-e2e tests on capz #24935

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Support pull-cloud-provider-azure-e2e tests on capz #24935

merged 1 commit into from
Feb 9, 2022

Conversation

lzhecheng
Copy link
Contributor

@lzhecheng lzhecheng commented Jan 20, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @lzhecheng!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lzhecheng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 20, 2022
@lzhecheng lzhecheng force-pushed the capz-migration-e2e branch 2 times, most recently from 7f961d0 to 839c364 Compare January 25, 2022 01:50
@lzhecheng
Copy link
Contributor Author

@chewong @khenidak Hello! Do you have time to review? Or could you please assign someone else to review?

@lzhecheng
Copy link
Contributor Author

@nilo19 Hello, please take a look at the PR.

nilo19
nilo19 reviewed Jan 25, 2022
View reviewed changes
config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
@@ -258,6 +258,46 @@ presubmits:
testgrid-tab-name: pr-cloud-provider-azure-e2e-ccm-vmss
description: "Runs Azure specific tests with cloud-provider-azure (https://github.com/kubernetes-sigs/cloud-provider-azure)."
testgrid-num-columns-recent: '30'
- name: pull-cloud-provider-azure-e2e-capz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull-cloud-provider-azure-e2e enables MixedProtocolLBService feature gate. Have you tested if the capz cluster enabled it as well?

Copy link
Contributor Author

@lzhecheng lzhecheng Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding. I will pay attention to feature gates in yaml files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added env var TEST_CCM: "true" for pull-cloud-provider-azure-e2e-capz, then this check has the same yaml file as the already existing pull-cloud-provider-azure-e2e-ccm-capz. Besides, according to the old aks-engine checks' config files, these 2 checks should have the same cluster config.

@lzhecheng lzhecheng force-pushed the capz-migration-e2e branch 3 times, most recently from 088bff5 to d4d085e Compare January 27, 2022 02:07
@nilo19
Copy link
Member

nilo19 commented Jan 27, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022
@lzhecheng lzhecheng mentioned this pull request Jan 28, 2022
Merged
@lzhecheng lzhecheng force-pushed the capz-migration-e2e branch 2 times, most recently from 95f7bab to 0654979 Compare January 30, 2022 01:31
@nilo19
Copy link
Member

nilo19 commented Feb 8, 2022

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2022
@nilo19
Copy link
Member

nilo19 commented Feb 8, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@lzhecheng
Support pull-cloud-provider-azure-e2e tests on capz
1f8f516 
Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@nilo19
Copy link
Member

nilo19 commented Feb 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@lzhecheng
Copy link
Contributor Author

/assign @khenidak

@nilo19
Copy link
Member

nilo19 commented Feb 8, 2022

/approve

@nilo19
Copy link
Member

nilo19 commented Feb 8, 2022

@feiskyer could you help to approve?

feiskyer
feiskyer reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lzhecheng, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@lzhecheng
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit e33494d into kubernetes:master Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

@lzhecheng: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
  • key cloud-provider-azure-presubmit-0.7.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-presubmit-0.7.yaml
  • key cloud-provider-azure-presubmit-1.0.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-presubmit-1.0.yaml
  • key cloud-provider-azure-presubmit-1.1.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-presubmit-1.1.yaml
  • key cloud-provider-azure-presubmit-1.23.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-presubmit-1.23.yaml

In response to this:

Signed-off-by: Zhecheng Li zhechengli@microsoft.com

related: #24957

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng deleted the capz-migration-e2e branch February 9, 2022 06:15
This was referenced Feb 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilo19 nilo19 nilo19 left review comments

@feiskyer feiskyer feiskyer left review comments

@chewong chewong Awaiting requested review from chewong

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

@khenidak khenidak

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
5 participants
@lzhecheng @k8s-ci-robot @nilo19 @feiskyer @khenidak