Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate aks-engine e2e test #919

Closed
nilo19 opened this issue Nov 29, 2021 · 13 comments
Closed

Deprecate aks-engine e2e test #919

nilo19 opened this issue Nov 29, 2021 · 13 comments
Assignees

Comments

@nilo19
Copy link
Contributor

nilo19 commented Nov 29, 2021

What would you like to be added:

Deprecate aks-engine based e2e test and migrate to use capz.

Why is this needed:

@nilo19 nilo19 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2021
@nilo19 nilo19 added kind/testing and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 21, 2021
@lzhecheng
Copy link
Contributor

/assign

@feiskyer
Copy link
Member

Per https://github.com/Azure/aks-engine:

This project is deprecated for Azure public cloud customers. Please consider using Azure Kubernetes Service (AKS) for managed Kubernetes or Cluster API Provider Azure for self-managed Kubernetes. There are no new features planned; this project will only be updated for CVEs & similar, with Kubernetes 1.24 as the final version to receive updates.

@bridgetkromhout
Copy link

Currently in progress.

@bridgetkromhout
Copy link

Waiting for CAPZ team to refactor: kubernetes-sigs/cluster-api-provider-azure#1994 (comment)

@bridgetkromhout
Copy link

@lzhecheng Please take a look at Azure/aks-engine#4874 - thanks.

@lzhecheng
Copy link
Contributor

I will start adding templates into cloud-provider-azure repo. Here is one of the prerequisite issue.
kubernetes-sigs/cluster-api-provider-azure#2299

@lzhecheng
Copy link
Contributor

An issue on test-infra repo
kubernetes/test-infra#24957

@jackfrancis
Copy link
Contributor

Great to see this woork @lzhecheng!

Because "Basic" LoadBalancer is not supported in capz, will we keep that AKS Engine test in cloud-provider-azure indefinitely?

cc @CecileRobertMichon @bridgetkromhout @ritazh

@lzhecheng
Copy link
Contributor

@jackfrancis as far as I know, basic lb and autoscaling will be verified in downstream tests on aks clusters.

@jackfrancis
Copy link
Contributor

@lzhecheng
Copy link
Contributor

@lzhecheng Thanks for confirming. May I remove this (and other similar) test jobs?:

I have no strong opinion. I didn't remove these tests because there's no harm to keep them and aks clustesr jobs are not ready yet. Gradually, they will be deleted with the whole release-branch.

@bridgetkromhout
Copy link

basic lb and autoscaling will be verified in downstream tests on aks clusters.

@lzhecheng Do we need to open an issue to make sure this happens? Do we know who is going to prepare those tests? Thanks.

@lzhecheng
Copy link
Contributor

basic lb and autoscaling will be verified in downstream tests on aks clusters.

@lzhecheng Do we need to open an issue to make sure this happens? Do we know who is going to prepare those tests? Thanks.

I have created one #1929 and I think @mainred will take the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants