Add a 'tidepoolerrors' Prometheus counter metric. #14792
Conversation
| @@ -354,6 +364,7 @@ func (c *Controller) Sync() error { | |||
| func(sp *subpool) { | |||
| pool, err := c.syncSubpool(*sp, blocks.GetApplicable(sp.org, sp.repo, sp.branch)) | |||
| if err != nil { | |||
| tideMetrics.poolErrors.WithLabelValues(sp.org, sp.repo, sp.branch).Inc() | |||
There was a problem hiding this comment.
/b/f/w/prow/tide/tide.go:186:3: unknown field 'poolErrors' in struct literal of type struct { pooledPRs *prometheus.GaugeVec; updateTime *prometheus.GaugeVec; merges *prometheus.HistogramVec; syncDuration prometheus.Gauge; statusUpdateDuration prometheus.Gauge }
bizarre
There was a problem hiding this comment.
oh, you need to add a field to the anonymous struct.
|
/retest |
| @@ -354,6 +364,7 @@ func (c *Controller) Sync() error { | |||
| func(sp *subpool) { | |||
| pool, err := c.syncSubpool(*sp, blocks.GetApplicable(sp.org, sp.repo, sp.branch)) | |||
| if err != nil { | |||
| tideMetrics.poolErrors.WithLabelValues(sp.org, sp.repo, sp.branch).Inc() | |||
There was a problem hiding this comment.
oh, you need to add a field to the anonymous struct.
|
/retest Review the full test history for this PR. Silence the bot with an |
1d7b2d2 to
76e6b5b
Compare
|
I fixed the compile error yesterday, but forgot to push my changes 🤦♂️ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll follow Steve's PRs to add this metric, create a dashboard, and configure alerts:
Metric: #13376
Dashboard: #13386
Alert: #13506
/assign @stevekuznetsov