Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dashboard to show ConfigMap sizes #13386

Conversation

stevekuznetsov
Copy link
Contributor

/assign @hongkailiu

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 10, 2019
@stevekuznetsov
Copy link
Contributor Author

@hongkailiu how can we get the jb and gojsontoyaml in go.mod correctly?

@stevekuznetsov stevekuznetsov force-pushed the skuznets/configmap-size-dashboard branch from f0bc896 to 9340145 Compare July 10, 2019 18:42
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2019
@hongkailiu
Copy link
Contributor

I would exclude the commit "These files got updated with make install".

@stevekuznetsov stevekuznetsov force-pushed the skuznets/configmap-size-dashboard branch from 9340145 to 76e3a24 Compare July 10, 2019 18:54
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2019
@stevekuznetsov stevekuznetsov force-pushed the skuznets/configmap-size-dashboard branch 3 times, most recently from fe545b7 to 78670ab Compare July 11, 2019 20:50
@stevekuznetsov stevekuznetsov changed the title [WIP] Add a dashboard to show ConfigMap sizes Add a dashboard to show ConfigMap sizes Jul 11, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2019
@stevekuznetsov
Copy link
Contributor Author

@cjwagner @hongkailiu PTAL

Screenshot from 2019-07-11 13-49-39

@stevekuznetsov
Copy link
Contributor Author

One weirdness is what happens when we have data for a configmap from multiple hook replicas ... I can't find a "newest" aggregation operator, could use max or average i guess and get a reasonable approximation, WDYT?

@hongkailiu
Copy link
Contributor

One weirdness is what happens when we have data for a configmap from multiple hook replicas ... I can't find a "newest" aggregation operator, could use max or average i guess and get a reasonable approximation, WDYT?

I think we should figure out why the newest data are not available.
I would start with our own production (i did saw the same thing yesterday there) and check if prometheus give the right answer. I would give us an idea that it is prometheus or grafana to blame. :)

@hongkailiu
Copy link
Contributor

/lgtm
/approve

/hold

let us block merges before #13401 gets in.

Just checked our production. Current values do show up.
We can follow up the next time hitting the issue.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d31007063ec49fb9d7cfadb59b54a7ad6cf1bef1

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/configmap-size-dashboard branch from 78670ab to 16e71a4 Compare July 12, 2019 21:06
@k8s-ci-robot k8s-ci-robot added area/prow/bump Updates to the k8s prow cluster and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 12, 2019
@hongkailiu
Copy link
Contributor

/lgtm
/approve

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9f261d697a86798c546f961e1193dbc8b150249

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3ec2b79 into kubernetes:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants