-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dashboard to show ConfigMap sizes #13386
Add a dashboard to show ConfigMap sizes #13386
Conversation
@hongkailiu how can we get the |
f0bc896
to
9340145
Compare
I would exclude the commit "These files got updated with |
9340145
to
76e3a24
Compare
fe545b7
to
78670ab
Compare
@cjwagner @hongkailiu PTAL |
One weirdness is what happens when we have data for a configmap from multiple |
I think we should figure out why the |
/lgtm /hold let us block merges before #13401 gets in. Just checked our production. Current values do show up. |
LGTM label has been added. Git tree hash: d31007063ec49fb9d7cfadb59b54a7ad6cf1bef1
|
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
78670ab
to
16e71a4
Compare
/lgtm /hold cancel |
LGTM label has been added. Git tree hash: a9f261d697a86798c546f961e1193dbc8b150249
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @hongkailiu