Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a hacky workaround to support pushing images from Jenkins #357

Closed
wants to merge 1 commit into from

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jun 29, 2017

I attempted to use #355 in the cross-build job, but it failed for two reasons:

  • the version of docker on Jenkins is old enough (1.9.1) that it doesn't embed manifest.json in saved docker images.
  • Jenkins doesn't have jq installed

Fixing this on Jenkins is a nontrivial process; until we do that, there are hacky workarounds.

x-ref kubernetes/test-infra#1400

/assign @david-mcmahon
cc @luxas @madhusudancs @roberthbailey

@david-mcmahon
Copy link
Contributor

Well that's sufficiently gross. :) Not having access to jq is going to be a big hindrance to getting anago running generally via jenkins as well. I guess there's nowhere else that need jq from jenkins? Is there a more general solution for jq-less environments here?

@david-mcmahon david-mcmahon added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2017
@ixdy
Copy link
Member Author

ixdy commented Jun 30, 2017

We probably should just install jq on the Jenkins VMs, though I'm not sure how involved of a process that will be.

@david-mcmahon
Copy link
Contributor

/lgtm

@ixdy
Copy link
Member Author

ixdy commented Jun 30, 2017

I think I'm going to focus on kubernetes/test-infra#3274 instead.

@roberthbailey
Copy link
Contributor

Shall we close this PR then?

@ixdy ixdy closed this Jun 30, 2017
@ixdy ixdy deleted the technical-debt branch June 30, 2017 05:06
@david-mcmahon
Copy link
Contributor

I did lgtm this, but I'm also quite happy to have jq on the jenkins images. And by gross, of course I meant awesome regex-slingin' (which I do appreciate!). Thanks for doing this.

@ixdy
Copy link
Member Author

ixdy commented Jun 30, 2017

getting everything to run inside a container so it's isolated from the environment of Jenkins (or prow) is still the ideal end goal, of course.

(I briefly considered either putting push-build.sh inside a container, or using one of the jq docker images. Not sure whether that's better or worse than installing jq on the Jenkins VMs.)

marpaia pushed a commit to marpaia/release that referenced this pull request Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants