push-build.sh: push docker images from tarfiles #355
Conversation
|
If the intention here is to replace release::docker::release(), why not do that all here as well too? |
|
This won't work for older releases (<k8s 1.8). I'm not sure I want to cherrypick my changes back. At some point we could probably get rid of the existing |
|
put another way: I don't want to change anything about |
|
Maybe check for /release-images/ somewhere here and dynamically use local images if they exist? Then this is backward compat and we can eventually remove |
|
That's fine. I'd prefer to leave things in a state where they Just Work under any condition/version, but this can certainly co-exist. Please put loud TODOs here with context though so we eventually clean up. |
|
Good suggestions. I've made |
| logrun docker rmi "$registry/$legacy_docker_target" || true | ||
| logrun -r 5 -s docker tag "$registry/$docker_target" \ | ||
| "$registry/$legacy_docker_target" 2>/dev/null | ||
| logecho |
There was a problem hiding this comment.
github does a terrible job displaying the diff, but I basically just indented here.
|
the PR in k/k has merged. PTAL? |
|
I don't have enough experience with these scripts to say anything, but I guess it's ok for me if it works ;) |
|
/lgtm |
|
gonna merge. this seems to work locally, but I'll watch CI/PR builds to make sure things are still working. fyi @krzyzacy @dchen1107 |
Adds a
--docker-registryflag to push-build.sh; if set, all images in_output/release-imageswill be pushed to the specified registry/project.Depends on kubernetes/kubernetes#47939.
A part of addressing kubernetes/test-infra#1400.
cc @luxas @madhusudancs @roberthbailey