Reduce handling of Github during stage and release #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold for discussion in https://kubernetes.slack.com/archives/G0162T1RYHG/p1623901053068200 |
justaugustus
requested changes
Jun 17, 2021
There was a problem hiding this comment.
@puerco -- Looking good; just a few message nits.
/hold until you're happy with the test stages/releases
pkg/release/workspace.go
Outdated
|
|
||
| repo, err := git.OpenRepo(directory) | ||
| if err != nil { | ||
| return errors.Wrap(err, "opening sytaged clone of k/k") |
There was a problem hiding this comment.
Suggested change
| return errors.Wrap(err, "opening sytaged clone of k/k") | |
| return errors.Wrap(err, "opening staged clone of k/k") |
There was a problem hiding this comment.
Both nits are done, sorry batteries are out 🔋
krel now resets the origin remote on the stages clone of kubernetes/kubernetes. If for some reasone we need to change the github token between staging and release, krel will now reset it in the staged sources. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Since all git operations in kubernetes/kubernetes during stage only involve the local clone of the repository, we do not set the authenticated git remote to avoid the risk of the token ending in the stage bucket. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
To avoid having the github token archived in the release bucket, we now destroy the git remote configuration before archiving the release. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
|
/lgtm Rate limit: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tested and verified. |
|
OK, this one is ready. |
This was referenced Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces the following changes:
krel now resets the origin remote on the staged clone of kubernetes/kubernetes. If for some reason we need to change the Github token between staging and release, krel will now reset it in the staged sources.
Since all git operations in kubernetes/kubernetes during stage only involve the local clone of the repository, we do not set the authenticated git remote to avoid the risk of the token ending in the stage bucket.
During the release stage, to avoid having the github token archived in the release bucket, we now destroy the git remote configuration before archiving the release.
Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net
Which issue(s) this PR fixes:
Fixes #1645
Special notes for your reviewer:
/priority critical-urgent
/assign @justaugustus @jeremyrickard @saschagrunert
/milestone v1.22
Does this PR introduce a user-facing change?