Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #102306: Return UnschedulableAndUnresolvable instead of Error when #102465: Return UnschedulableAndUnresolvable when looking up #102515

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Automated cherry pick of #102306: Return UnschedulableAndUnresolvable instead of Error when #102465: Return UnschedulableAndUnresolvable when looking up #102515

merged 2 commits into from
Jun 8, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jun 2, 2021 •
edited
Loading

Cherry pick of #102306 #102465 on release-1.20.

#102306: Return UnschedulableAndUnresolvable instead of Error when
#102465: Return UnschedulableAndUnresolvable when looking up

Part of #102305

For details on the cherry pick process, see the cherry pick requests page.

@ahg-g
Return UnschedulableAndUnresolvable instead of Error when failing to …
e160aa0 
…lookup pvc or storageclass in VolumeZone plugin
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 2, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 2, 2021

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 2, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 2, 2021

@kubernetes/release-managers

@ahg-g
Copy link
Member Author

ahg-g commented Jun 2, 2021

/retest

1 similar comment
@ahg-g
Copy link
Member Author

ahg-g commented Jun 2, 2021

/retest

@ahg-g ahg-g force-pushed the automated-cherry-pick-of-#102306-#102465-upstream-release-1.20 branch from d0cc560 to ef655bd Compare June 2, 2021 02:52
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 8, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 8, 2021
@puerco
Copy link
Member

puerco commented Jun 8, 2021 •
edited
Loading

Quick question about cherry picking this to 1.19:
#102514 (comment)

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 8, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 8, 2021

Quick question about cherry picking this to 1.19:
#102514 (comment)

created #102695

@k8s-ci-robot k8s-ci-robot merged commit dcec9a8 into kubernetes:release-1.20 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@ahg-g @k8s-ci-robot @alculquicondor @puerco @feiskyer