Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler VolumeZone plugin returns error instead of unschedulable #102305

Closed
ahg-g opened this issue May 25, 2021 · 2 comments
Closed

Scheduler VolumeZone plugin returns error instead of unschedulable #102305

ahg-g opened this issue May 25, 2021 · 2 comments
Assignees
@ahg-g
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@ahg-g
Copy link
Member

ahg-g commented May 25, 2021

Scheduler VolumeZone plugin returns error when a PVC or StorageClass is not found. This is not really a scheduler error, and so we should be returning Unschedulable instead of Error. This is important to properly track errors in logs as well as scheduler_attempts metric.

/sig scheduling
/assign
/cc @cofyc
@ahg-g ahg-g added the kind/feature Categorizes issue or PR as related to a new feature. label May 25, 2021
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 25, 2021
@k8s-ci-robot
Copy link
Contributor

@ahg-g: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 25, 2021
@ahg-g ahg-g mentioned this issue May 25, 2021
Merged
@ahg-g
Copy link
Member Author

ahg-g commented May 25, 2021

We will patch this back to 1.21 and 1.20

This was referenced Jun 1, 2021
Merged
Merged
Merged
@ahg-g ahg-g closed this as completed Jun 28, 2021
@Gekko0114 Gekko0114 mentioned this issue Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahg-g ahg-g

Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k8s-ci-robot @ahg-g