Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional error state #2019

Closed
wants to merge 3 commits into from
Closed

Additional error state #2019

wants to merge 3 commits into from

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Mar 16, 2023 •
edited
Loading

  1. Consolidate error states for node(using only ErrInvalidNode), and create error states for invalid pod information.
  2. Add TestValidateEndpointFields to verify if the error states are triggered as expected.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 16, 2023
@sawsa307
Copy link
Contributor Author

/assign @swetharepakula

@sawsa307 sawsa307 force-pushed the additional-error-state branch 2 times, most recently from bb0b5be to ad344c7 Compare March 16, 2023 22:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 16, 2023
@sawsa307
Copy link
Contributor Author

/assign @bowei

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2023
@bowei
Copy link
Member

bowei commented Mar 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2023
@sawsa307 sawsa307 force-pushed the additional-error-state branch from ad344c7 to 5070d74 Compare March 21, 2023 00:12
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please ask for approval from bowei. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2023
@sawsa307 sawsa307 force-pushed the additional-error-state branch from 5070d74 to 33bb5a4 Compare March 21, 2023 00:15
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2023
@sawsa307 sawsa307 force-pushed the additional-error-state branch 4 times, most recently from e2ecd4e to 2ca57e6 Compare March 21, 2023 21:47
@sawsa307 sawsa307 force-pushed the additional-error-state branch from 2ca57e6 to adedafd Compare March 22, 2023 00:07
sawsa307 added a commit to sawsa307/ingress-gce that referenced this pull request Mar 22, 2023
@sawsa307
kubernetes#2019
9a4c233
@sawsa307 sawsa307 mentioned this pull request Mar 22, 2023
Closed
@sawsa307 sawsa307 force-pushed the additional-error-state branch from adedafd to 5e79250 Compare March 23, 2023 03:30
sawsa307 added 2 commits March 23, 2023 03:34
@sawsa307
Add details to error-state errors in toZoneNetworkEndpointMap
e0e65e6
@sawsa307
Additional error states
b9c5662 
1. Consolidate error states for node, and create error states for pod
   information.
2. Add TestValidateEndpointFields to verify if the error states are
   triggered as expected.
@sawsa307 sawsa307 force-pushed the additional-error-state branch from 5e79250 to b9c5662 Compare March 23, 2023 03:35
sawsa307 added a commit to sawsa307/ingress-gce that referenced this pull request Mar 23, 2023
@sawsa307
kubernetes#2019
4c13d18
@sawsa307 sawsa307 closed this Mar 28, 2023
@sawsa307 sawsa307 deleted the additional-error-state branch September 2, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@cezarygerard cezarygerard Awaiting requested review from cezarygerard

Assignees

@bowei bowei

@swetharepakula swetharepakula

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @k8s-ci-robot @bowei @swetharepakula