-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA: Updating AWS-SDK-Go to 1.26.6 #2750
CA: Updating AWS-SDK-Go to 1.26.6 #2750
Conversation
Also updates the AWS-Manager test for Region fetching due to changes in the SDK in how this is done Updating vendor against git@github.com:kubernetes/kubernetes.git:711790af23a231ade04c6c39d6bc5dcf1a996f73 (711790a)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @Jeffwan |
Thanks! Seems this is a prerequisite for the next step. Let's merge this dependency update separately. Looks good to me /lgtm |
/hold I've just had a look again and am seeing more changes than I expected, particularly in vendored files under a Looks like these reversions are all reversions of changes brought in by #2605 . They seem unrelated to the changes intended by that PR, but could you please confirm @jaypipes just to be certain. |
@gjtempleton nope, these changes are all good. This PR is adding the new aws-sdk-go 1.26.6 package to the In short, we're all good here :) |
Brilliant, thanks for the confirmation! /hold cancel |
@gjtempleton: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This brings in the new EC2
DescribeInstanceTypes
API.Also updates the AWS-Manager test for Region fetching due to changes in the SDK in how this is done due to aws/aws-sdk-go#2969
Updating vendor against git@github.com:kubernetes/kubernetes.git:711790af23a231ade04c6c39d6bc5dcf1a996f73 (711790a)
Broken out from the changes to the EC2 instance type list enabled by this SDK update to simplify reviewing of the PRs.
Related to #2696