Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-copied github.com/digitalocean/godo #2605

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

jaypipes
Copy link
Contributor

@jaypipes jaypipes commented Dec 2, 2019

Adds the github.com/digitalocean/godo dependency as a go mod instead of
copied into the cluster-autoscaler/cloudprovider/digitalocean/godo
directory.

Adds the github.com/digitalocean/godo dependency as a go mod instead of
copied into the cluster-autoscaler/cloudprovider/digitalocean/godo
directory.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2019
@jaypipes
Copy link
Contributor Author

jaypipes commented Dec 2, 2019

/assign @losipiuk

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 2, 2019
@losipiuk
Copy link
Contributor

losipiuk commented Dec 2, 2019

Thanks!

/lgtm
/approve

/hold
@snormore PTAL.
I will lift the hold in couple of days if you do not have any objections.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming lazy consensus. Lifting the hold.

@mwielgus mwielgus removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7c45ece into kubernetes:master Dec 9, 2019
@jaypipes jaypipes deleted the go-mod-cleanup-godo branch December 11, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants