Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment/helm: add resourceLabels to master args #793

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Mar 23, 2022

Closes: #789

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mythi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok March 23, 2022 05:30
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 23, 2022
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume you have verified that this works, because I haven't 😅
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@mythi
Copy link
Contributor Author

mythi commented Mar 23, 2022

my test case:

$ helm install node-feature-discovery  --set master.resourceLabels=sgx.intel.com/epc --set master.extraLabelNs=sgx.intel.com --namespace node-feature-discovery --create-namespace --generate-name
NAME: node-feature-discovery-1648023667
LAST DEPLOYED: Wed Mar 23 10:21:07 2022
NAMESPACE: node-feature-discovery
STATUS: deployed
REVISION: 1
TEST SUITE: None
$ kubectl get pod node-feature-discovery-1648023667-master-6579ccc8bf-cfwph -n node-feature-discovery -o json | jq .spec.containers[0].args
[
  "--extra-label-ns=sgx.intel.com",
  "--resource-labels=sgx.intel.com/epc",
  "-featurerules-controller=true"
]
$ helm uninstall node-feature-discovery-1648023667 -n node-feature-discovery
release "node-feature-discovery-1648023667" uninstalled
$ helm install node-feature-discovery  --namespace node-feature-discovery --create-namespace --generate-nameNAME: node-feature-discovery-1648023969
LAST DEPLOYED: Wed Mar 23 10:26:09 2022
NAMESPACE: node-feature-discovery
STATUS: deployed
REVISION: 1
TEST SUITE: None
$ kubectl get pod node-feature-discovery-1648023969-master-86dd7c7f76-b2f7m -n node-feature-discovery -o json | jq .spec.containers[0].args
[
  "-featurerules-controller=true"
]

@marquiz
Copy link
Contributor

marquiz commented Mar 23, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2b22711 into kubernetes-sigs:master Mar 23, 2022
@marquiz marquiz mentioned this pull request Mar 28, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm: master: add templating for resource-labels
3 participants