Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: master: add templating for resource-labels #789

Closed
mythi opened this issue Mar 18, 2022 · 2 comments · Fixed by #793
Closed

helm: master: add templating for resource-labels #789

mythi opened this issue Mar 18, 2022 · 2 comments · Fixed by #793
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mythi
Copy link
Contributor

mythi commented Mar 18, 2022

What would you like to be added:
I would like to be able to set --resource-labels master args when using Helm for deployment. When this is set, also the RBAC rules must be updated.

Why is this needed:
To improve Helm based templating.

@mythi mythi added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 18, 2022
@marquiz
Copy link
Contributor

marquiz commented Mar 18, 2022

Would be a nice improvement. Patches are welcome 😉
/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@marquiz:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Would be a nice improvement. Patches are welcome 😉
/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants