dockerfile: builder image configurable through a Makefile variable. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch over to the "non-point-release" version of the image. Now we always use the latest patch version of golang with latest security fixes, for example, without the need to manually bump the version after every point release. This patch also makes the builder image configurable through a Makefile variable pointing to the go.mod go version, that way the go.mod file becomes the source of truth for the go version.
665f699 to
fc05aa1
Compare
|
/assign @marquiz |
marquiz
reviewed
Jan 19, 2023
marquiz
reviewed
Jan 19, 2023
There was a problem hiding this comment.
Thanks @ArangoGutierrez! Makes sense, only one suggestion regarding the shell script snippet for parsing the go version from go.mod.
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
approved these changes
Jan 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch over to the "non-point-release" version of the image. Now we always use the latest patch version of golang with latest security fixes, for example, without the need to manually bump the version after every point release.
This patch also makes the builder image configurable through a Makefile variable pointing to the go.mod go version, that way the go.mod file becomes the source of truth for the go version.