Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to sync with Operand #170

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

This patch:

  • Update Go to 1.19
  • Update to Kubernetes 1.26
  • Update Ginko to V2

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
As seen in:
kubernetes-sigs/controller-runtime#1977

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from zvonkok January 16, 2023 10:49
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 16, 2023
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez
/lgtm

On a sidenote, we might want to do something like kubernetes-sigs/node-feature-discovery#836 in the operator, too. I.e. let master track the latest bugfix version of golang. On a release branch we'd then need to pin a version (for reproducibility of builds)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@ArangoGutierrez
Copy link
Contributor Author

Good idea

@k8s-ci-robot k8s-ci-robot merged commit 41f5a02 into kubernetes-sigs:master Jan 16, 2023
@ArangoGutierrez
Copy link
Contributor Author

Thanks @ArangoGutierrez /lgtm

On a sidenote, we might want to do something like kubernetes-sigs/node-feature-discovery#836 in the operator, too. I.e. let master track the latest bugfix version of golang. On a release branch we'd then need to pin a version (for reproducibility of builds)

#173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants