Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop operand.namespace #115

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Drop operand.namespace #115

merged 3 commits into from
Feb 8, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Fixes #114

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2022
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-node-feature-discovery-operator-verify 73bfac9 link true /test pull-node-feature-discovery-operator-verify
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

ups.... topology things got into the PR jejeje

@ArangoGutierrez ArangoGutierrez mentioned this pull request Feb 7, 2022
Closed
marquiz
marquiz requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits don't seem to be consistent as the first commit already drops operand.namespace. Either squash the commits into one or only do make manifests in the first commit.

Also, commit messages (that do not have a "topic: " prefix) should begin with a capital letter.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 8, 2022
@ArangoGutierrez
Drop operand.namespace from CRD
7c09709 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

drop operand.namespace

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 8, 2022
marquiz
marquiz reviewed Feb 8, 2022
View reviewed changes
controllers/nodefeaturediscovery_controller.go Show resolved Hide resolved
main.go Outdated
Comment on lines 86 to 90
watchNamespace, err := utils.GetWatchNamespace()
if err != nil {
klog.Error(err, "unable to get WatchNamespace, "+
"the manager will watch and manage resources in all namespaces")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woudln't it be ok to watch for all namespaces by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if https://github.com/ArangoGutierrez/node-feature-discovery-operator/blob/devel/v1spec_ns/pkg/utils/utils.go#L28 is not defined, if will default to all, so is ok.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K. The error in log is a bit misleading here, I think. Would klog.Infof() or smth be better?

Suggested change
watchNamespace, err := utils.GetWatchNamespace()
if err != nil {
klog.Error(err, "unable to get WatchNamespace, "+
"the manager will watch and manage resources in all namespaces")
}
watchNamespace, found := os.LookupEnv(watchNamespaceEnvVar)
if !found {
klog.Infof("%q not specified in env, the manager will watch and manage resources in all namespaces", watchNamespaceEnvVar)
}

marquiz
marquiz reviewed Feb 8, 2022
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the devel/v1spec_ns branch 3 times, most recently from d22a5a6 to f833220 Compare February 8, 2022 15:50
@ArangoGutierrez @marquiz
Enhance GetWatchNamespace func
e51c5a9 
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
@ArangoGutierrez ArangoGutierrez force-pushed the devel/v1spec_ns branch 2 times, most recently from e590d1f to c880bc7 Compare February 8, 2022 16:14
@ArangoGutierrez @marquiz
Document the WATCH_NAMESPACE behavior
b4fd7e3 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

Update docs/get-started/quick-start.md

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>

Update docs/get-started/quick-start.md

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
marquiz approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to get in 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 652f353 into kubernetes-sigs:master Feb 8, 2022
@ArangoGutierrez ArangoGutierrez added this to the v0.4.0 milestone Feb 9, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request Feb 9, 2022
Closed
14 tasks
@ArangoGutierrez ArangoGutierrez deleted the devel/v1spec_ns branch March 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

operand.namespace should be dropped
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz