Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operand.namespace should be dropped #114

Closed
marquiz opened this issue Jan 25, 2022 · 1 comment · Fixed by #115
Closed

operand.namespace should be dropped #114

marquiz opened this issue Jan 25, 2022 · 1 comment · Fixed by #115
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@marquiz
Copy link
Contributor

marquiz commented Jan 25, 2022

What happened:

I create nfd CR:

kubectl apply -f - << EOF
apiVersion: nfd.kubernetes.io/v1
kind: NodeFeatureDiscovery
metadata:
  name: nfd-master-server
  namespace: operators
spec:
  operand:
    image: 'k8s.gcr.io/nfd/node-feature-discovery:v0.10.1'
    namespace: nfd
EOF

NFD get's deployed in operators namespace, as it should. The operand.namespace field has no effect (as it shouldn't as it shouldn't be allowed to "contaminate" arbitrary namespaces with NFD) and it should be dropped from the CRD.

What you expected to happen:

The operand.namespace parameter should not be accepted at al.

How to reproduce it (as minimally and precisely as possible):

See above.

Anything else we need to know?:

@marquiz marquiz added the kind/bug Categorizes issue or PR as related to a bug. label Jan 25, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jan 27, 2022

/retitle operand.namespace should be dropped

@k8s-ci-robot k8s-ci-robot changed the title operand.namespace has no effect operand.namespace should be dropped Jan 27, 2022
ArangoGutierrez added a commit to ArangoGutierrez/node-feature-discovery-operator that referenced this issue Feb 8, 2022
Fixes kubernetes-sigs#114

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

drop operand.namespace

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant