-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with replacements #3931
Fix issues with replacements #3931
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b9074d1
to
f0fbcb2
Compare
c9528ca
to
d555ce1
Compare
d555ce1
to
81a5602
Compare
@natasha41575 Excellent job in the first commit establishing issue behavior, and then fixing it in a subsequent commit. |
5959e90
to
059c8bb
Compare
059c8bb
to
f8707b3
Compare
f8707b3
to
84724a3
Compare
/lgtm |
Does it also fixes this kind of issues?
Because this also does not seem to work with kustomize v4.1.3 |
@616b2f just as an FYI this PR does provide functionality to escape your delimiters, e.g. |
@natasha41575 thank you for clarification and opening the new bug. Btw. I love the new feature you implemented, it's really saved us a lot of pain. |
First commit demonstrates #3927, second demonstrates #3928.
Third commit fixes #3927, fourth fixes #3928.