Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat first crictl stats argument as filter ID #512

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Treat first crictl stats argument as filter ID #512

merged 1 commit into from
Aug 30, 2019

Conversation

saschagrunert
Copy link
Member

The first argument supplied to crictl stats can be taken as the filter
ID of the container, whereas --id gets precedence.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2019
@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@yujuhong
Copy link
Contributor

/lgtm

@saschagrunert
Treat first crictl stats argument as filter ID
5cc722b 
The first argument supplied to `crictl stats` can be taken as the filter
ID of the container, whereas `--id` gets precedence.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2019
@saschagrunert
Copy link
Member Author

Rebased on top of the latest master branch to get the travis changes in.

feiskyer
feiskyer reviewed Aug 30, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit df1252c into kubernetes-sigs:master Aug 30, 2019
@saschagrunert saschagrunert deleted the stats-first-arg branch August 30, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@runcom runcom Awaiting requested review from runcom

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@feiskyer feiskyer

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @k8s-ci-robot @Random-Liu @yujuhong @feiskyer