Merge pull request #512 from openSUSE/stats-first-arg

Treat first `crictl stats` argument as filter ID
kubernetes-sigs · Aug 30, 2019 · df1252c · df1252c
2 parents 303e219 + 5cc722b
commit df1252c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/cmd/crictl/stats.go b/cmd/crictl/stats.go
@@ -50,6 +50,7 @@ var statsCommand = cli.Command{
 	Usage:                  "List container(s) resource usage statistics",
 	SkipArgReorder:         true,
 	UseShortOptionHandling: true,
+	ArgsUsage:              "[ID]",
 	Flags: []cli.Flag{
 		cli.BoolFlag{
 			Name:  "all, a",
@@ -90,9 +91,14 @@ var statsCommand = cli.Command{
 		}
 		defer closeConnection(context, runtimeConn)
 
+		id := context.String("id")
+		if id == "" && context.Args() != nil {
+			id = context.Args()[0]
+		}
+
 		opts := statsOptions{
 			all:    context.Bool("all"),
-			id:     context.String("id"),
+			id:     id,
 			podID:  context.String("pod"),
 			sample: time.Duration(context.Int("seconds")) * time.Second,
 			output: context.String("output"),