⚠ (:warning:, major) Do not disable admission plugins by default #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @mengqiy @DirectXMan12 @vincepri /hold for 0.6 |
| @@ -9,7 +9,7 @@ var APIServerDefaultArgs = []string{ | |||
| "--insecure-port={{ if .URL }}{{ .URL.Port }}{{ end }}", | |||
| "--insecure-bind-address={{ if .URL }}{{ .URL.Hostname }}{{ end }}", | |||
| "--secure-port={{ if .SecurePort }}{{ .SecurePort }}{{ end }}", | |||
| "--disable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,TaintNodesByCondition,Priority,DefaultTolerationSeconds,DefaultStorageClass,StorageObjectInUseProtection,PersistentVolumeClaimResize,ResourceQuota", //nolint | |||
| "--disable-admission-plugins=ServiceAccount", //nolint | |||
There was a problem hiding this comment.
can we remove the // nolint?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4040b01 to
bb3b4e5
Compare
bb3b4e5 to
b908ef1
Compare
|
@DirectXMan12 fixed, I also added comment |
|
/lgtm |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we enable ServiceAccount plugin, tests fail with this error. That is because controller normally takes care of creating default service account but that controller is not running in the integration environment.
We either keep that disabled by default or envtest would have to create that SA for the users? Otherwise all users would have to create that SA which I think is not desired.