Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envtest should not disable all admission plugins #837

Closed
alenkacz opened this issue Mar 5, 2020 · 3 comments
Closed

Envtest should not disable all admission plugins #837

alenkacz opened this issue Mar 5, 2020 · 3 comments
Assignees
Milestone

Comments

@alenkacz
Copy link
Contributor

alenkacz commented Mar 5, 2020

Right now, api-server is started by default with all admission plugins disabled

"--disable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,TaintNodesByCondition,Priority,DefaultTolerationSeconds,DefaultStorageClass,StorageObjectInUseProtection,PersistentVolumeClaimResize,ResourceQuota", //nolint
(before we were even using AlwaysAdmit).

This means that e.g. no error is given when namespace does not exist when you are creating resource in tests. We should enable all plugins and keep the env as close to production as possible.

@alenkacz
Copy link
Contributor Author

alenkacz commented Mar 5, 2020

/assign

cc. @mengqiy @DirectXMan12

@vincepri vincepri added this to the v0.6.0 milestone Mar 5, 2020
@mengqiy
Copy link
Member

mengqiy commented Apr 16, 2020

@alenkacz Any update on this? We are trying to burndown the v0.6.0 milestone list.

@DirectXMan12
Copy link
Contributor

#848 closes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants