Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The apiserver port is hard-coded #559

Closed
flaper87 opened this issue Oct 25, 2018 · 4 comments · Fixed by #734
Closed

The apiserver port is hard-coded #559

flaper87 opened this issue Oct 25, 2018 · 4 comments · Fixed by #734
Assignees
@frapposelli @detiber
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1alpha1

Comments

@flaper87
Copy link
Contributor

clusterclient.go has a const with the apiserver port set to 443. This is not ideal as it forces deployments to use such port.

One way this could be solved is to add a GetEndpoint function that is capable of returning the full apiserver endpoint. Ideally, cluster-api should be smart enough to figure this out without depending on the provider.

Any opinions the above idea? Any thoughts on how this should be solved?
This was referenced Oct 25, 2018
Closed
Merged
@vincepri
Copy link
Member

vincepri commented Dec 4, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 4, 2018
@roberthbailey roberthbailey added this to the v1alpha1 milestone Jan 11, 2019
@roberthbailey roberthbailey added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 11, 2019
@detiber
Copy link
Member

detiber commented Jan 31, 2019

/help

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 31, 2019
@frapposelli
Copy link
Member

/assign

@frapposelli
Copy link
Member

/remove-help
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 7, 2019
@frapposelli frapposelli mentioned this issue Feb 7, 2019
Merged
k8s-ci-robot pushed a commit that referenced this issue Feb 7, 2019
@frapposelli @k8s-ci-robot
avoid hardcoding port in clusterclient.go (#734)
9153bcf 
In clusterclient.go client.UpdateClusterObjectEndpoint checks if the value
fetched from the provider is in the host:port format, if no port is present
appends the default API server port (443).

Fixes: #559
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request kubernetes-sigs#559 from datianshi/service_domain
1b8a92b 
Add service domain to the cluster config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frapposelli frapposelli

@detiber detiber

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1alpha1
Development

Successfully merging a pull request may close this issue.

Avoid hardcoding port in clusterclient.go
6 participants
@flaper87 @frapposelli @detiber @vincepri @roberthbailey @k8s-ci-robot