Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 443 until cluster-api is fixed #77

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

flaper87
Copy link
Contributor

@flaper87 flaper87 commented Oct 25, 2018

Use 443 as the apiserver port until cluster-api allows us to set a
different port instead of hard-coding it:

#64
kubernetes-sigs/cluster-api#559

Use 443 as the apiserver port until cluster-api allows us to set a
different port instead of hard-coding it:

kubernetes-sigs#64
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2018
@scruplelesswizard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit e26c079 into kubernetes-sigs:master Oct 25, 2018
flaper87 referenced this pull request in openshift/cluster-api-provider-openstack Nov 29, 2018
Use 443 as the apiserver port until cluster-api allows us to set a
different port instead of hard-coding it:

kubernetes-sigs#64
iamemilio pushed a commit to iamemilio/cluster-api-provider-openstack that referenced this pull request Jan 6, 2020
Bug 1751471: Apply update to workers selectively
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants