[WIP] Release 12.0 #1088
Closed
[WIP] Release 12.0 #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the __del__ function from the generated Python client, and replaces it with a cleanup function. When a ThreadPool is created, the cleanup function is registered with the atexit module. This PR also allows the client to be used as a context manager, which will automatically clean up after itself rather than having to wait til process exit. This fixes issue #1037, where the API client could hang indefinitely at garbage collection.
Cleanup ThreadPool with atexit rather than __del__
Document hot issues in release process
Grammar fixes to contributing doc
…into release-12.0
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: scottilee The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It looks like this PR is still WIP (it merges the master branch to the release branch). Please let me know when you have more updates and need review |
|
/cc |
|
Could you also track upgrading the upstream code generator in the description? |
This was referenced Mar 9, 2020
3 tasks
|
Closing this in favor of a new PR due to many merge conflicts and issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 12.0 introduces several changes and is compatible with Kubernetes v1.16.
Fixes #1052