make dateutil mandatory for api client #1084
Conversation
Avoids differing incompatible return types depending on what modules are installed at runtime. This is backward incompatible though likely the less breaking variation as most environments should have dateutils installed due to the requirements.txt. Closes kubernetes-clientgh-1081
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: juliantaylor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -18,6 +18,7 @@ | |||
| import os | |||
| import re | |||
| import tempfile | |||
| import dateutil.parser | |||
There was a problem hiding this comment.
This file is auto-generated by openapi-generator. Therefore this change won't persist when we re-generate the client.
This change has been made upstream OpenAPITools/openapi-generator#4316 v4.2.1. The change will be picked up when we upgrade to use the newer version (currently we are at v3.3.4)
|
/close #1088 will include the upstream generator upgrade (#1084 (comment)) |
|
@roycaihw: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoids differing incompatible return types depending on what modules are
installed at runtime.
This is backward incompatible though likely the less breaking variation
as most environments should have dateutils installed due to the
requirements.txt.
Closes gh-1081