include source maps in npm pack #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the generated source maps in the artifact published to npm. This commit also simplifies the patterns used to match files. Some files, such as README are always included, so it has been removed here. Refs: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#files Fixes: kubernetes-client#2249
cjihrig
commented
Feb 23, 2025
| @@ -8,13 +8,9 @@ | |||
| "url": "https://github.com/kubernetes-client/javascript.git" | |||
| }, | |||
| "files": [ | |||
| "dist/*.ts", | |||
There was a problem hiding this comment.
@brendandburns I guess we could use these patterns as a mechanism to only include certain source maps (referring to your comment here #2249 (comment)), but as I said on the other issue, I'm not sure that's worth doing.
|
/lgtm Thanks for cleaning this up. I don't feel strongly about excluding the generated map files, if it's easy to create them. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cjihrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the generated source maps in the artifact published to npm. This commit also simplifies the patterns used to match files. Some files, such as README are always included, so it has been removed here.
Refs: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#files
Fixes: #2249