-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Source Map Files in @kubernetes/client-node@1.0.0
Cause ~100 Vite Warnings
#2249
Comments
@kubernetes/client-node@1.0.0
Cause Vite Warnings@kubernetes/client-node@1.0.0
Cause ~100 Vite Warnings
I'm leaning toward removing the source maps. All of the transpiled files that I checked appear to be very readable and don't really benefit from having source maps. What do other folks think? |
We should definitely remove them for generated code. That's not meant to be read anyway. Is there a way that we can exclude for generated code, but retain for hand-written code? |
I'm not sure that we can do it without two separate build steps, but I'm also not 100% sure. I don't think it makes sense to disable them only for certain files though. Even though the generated code isn't meant to be read, you'd be stuck if you were trying to debug code that entered the generated code and that code happened to be unreadable. @MichaelJCole I realize you mostly just want the Vite warnings to go away, but as a user, do you think having or not having the source maps would make any difference to you? |
Hi, thanks for reading.
If there's a problem, I'll want a stack trace. If the code is transpiled (typescript->javascript) I'll want the stack trace in the source, not the transpired code.
How can users make issues/patches wo visibility in the source?
This module isn't for the browser, so size isn't a factor.
Why delete them at all? It just seems like extra work to mess up the tooling. But maybe I'm missing something.
Fwiw I decided to use caddy instead.
-------- Original Message --------
…On Feb 22, 2025, 9:14 PM, Colin Ihrig wrote:
I'm not sure that we can do it without two separate build steps, but I'm also not 100% sure. I don't think it makes sense to disable them only for certain files though. Even though the generated code isn't meant to be read, you'd be stuck if you were trying to debug code that entered the generated code and that code happened to be unreadable.
***@***.***(https://github.com/MichaelJCole) I realize you mostly just want the Vite warnings to go away, but as a user, do you think having or not having the source maps would make any difference to you?
—
Reply to this email directly, [view it on GitHub](#2249 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AALPMFSNNRXZESKXC6CN2ND2RE4J5AVCNFSM6AAAAABXUOQIR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGUZTIMZTGE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
[cjihrig]cjihrig left a comment [(kubernetes-client/javascript#2249)](#2249 (comment))
I'm not sure that we can do it without two separate build steps, but I'm also not 100% sure. I don't think it makes sense to disable them only for certain files though. Even though the generated code isn't meant to be read, you'd be stuck if you were trying to debug code that entered the generated code and that code happened to be unreadable.
***@***.***(https://github.com/MichaelJCole) I realize you mostly just want the Vite warnings to go away, but as a user, do you think having or not having the source maps would make any difference to you?
—
Reply to this email directly, [view it on GitHub](#2249 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AALPMFSNNRXZESKXC6CN2ND2RE4J5AVCNFSM6AAAAABXUOQIR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGUZTIMZTGE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This commit includes the generated source maps in the artifact published to npm. This commit also simplifies the patterns used to match files. Some files, such as README are always included, so it has been removed here. Refs: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#files Fixes: kubernetes-client#2249
Opened #2260 to include the source maps. You can test it by running |
Missing Source Map Files in
@kubernetes/client-node@1.0.0
Cause Vite WarningsDescription
The
@kubernetes/client-node
package (v1.0.0) includes source map comments (e.g.,//# sourceMappingURL=StorageV1alpha1Api.js.map
) in its generated JS files underdist/gen/apis/
, but the.map
files are not included in the npm package. This causes repeated "Failed to load source map" warnings in Vite (used by Nuxt 3) during development, cluttering logs and confusing developers. The warnings are cosmetic but degrade the dev experience due to a packaging issue.Steps to Reproduce
server/utils/ingress.ts
:plugins/test.server.ts
:npm run dev
and check logs.Expected Behavior
No source map warnings, either by including
.map
files or removing the comments.Actual Behavior
~100 Warnings like:
Examples
StorageV1alpha1Api.js
,CoreV1Api.js
,util.js
, etc.Why It’s a Problem
Clutters dev logs, confuses developers, adds minor overhead.
Suggested Fix
.map
files in the package, or//# sourceMappingURL=...
comments during build (e.g.,--sourceMap false
).Workaround
Patch locally with
patch-package
:Context
@kubernetes/client-node@1.0.0
The text was updated successfully, but these errors were encountered: