Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped reference to gson internal API #366

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Dropped reference to gson internal API #366

merged 1 commit into from
Sep 17, 2018

Conversation

ieugen
Copy link
Contributor

@ieugen ieugen commented Sep 12, 2018

  • fixes Remove dependency on GSON internal API #304
  • JSON class is ignored by swagger code gen - see kubernetes/.swagger-codegen-ignore
  • please document process around swagger code-gen so people can contribute
  • please separate generated code from developed code

* JSON class is ignored by swagger code gen
* please document process around swagger code-gen so people can contribute
* please separate generated code from developed code
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2018
@brendandburns
Copy link
Contributor

Here's the improved instructions:

#371

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ieugen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit f1819ee into kubernetes-client:master Sep 17, 2018
@ieugen ieugen deleted the remove-gson-internal-api branch September 18, 2018 08:27
fabiokung added a commit to fabiokung/java that referenced this pull request Oct 23, 2019
Reapply changes from kubernetes-client#366 to the code generated by openapi-generator,
and keep the JSON file pinned (ignored by the generator) until those
changes make it into the generator.
fabiokung added a commit to fabiokung/java that referenced this pull request Oct 24, 2019
Reapply changes from kubernetes-client#366 to the code generated by openapi-generator,
and keep the JSON file pinned (ignored by the generator) until those
changes make it into the generator.
fabiokung added a commit to fabiokung/java that referenced this pull request Oct 24, 2019
Reapply changes from kubernetes-client#366 to the code generated by openapi-generator,
and keep the JSON file pinned (ignored by the generator) until those
changes make it into the generator.
yue9944882 pushed a commit to yue9944882/java that referenced this pull request Nov 6, 2019
Reapply changes from kubernetes-client#366 to the code generated by openapi-generator,
and keep the JSON file pinned (ignored by the generator) until those
changes make it into the generator.
yue9944882 pushed a commit to yue9944882/java that referenced this pull request Nov 8, 2019
depends on yue9944882/gen#1

okhttp3 and models generated by openapi-generator

Changes required to make everything compile with models generated by
openapi-generator (instead of swagger-codegen).

These changes break backwards compatibility, it will require a new major
version release.

pin sundrio to 0.19.2

it includes sundrio/sundrio#156

reformat code (./mvnw fmt)

depend on javax.annotation:javax.annotation-api

to make javax.annotation.Generated work with Java 9

prevent Travis builds failing because of no output

... when tests take more than 10min to complete.

javadoc generation for http.response.details

drop the TODO, not needed anymore

remove reference to swagger-codegen

no gson internals for date parsing/formatting

Reapply changes from kubernetes-client#366 to the code generated by openapi-generator,
and keep the JSON file pinned (ignored by the generator) until those
changes make it into the generator.

regenerate code with SSL bootstrapping fix

Using a generator with OpenAPITools/openapi-generator#4226 applied.

re-generate from v4.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on GSON internal API
3 participants