-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JSON.java from openapi ignore file. #2818
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
telling from the comment, looks like we're stopping JSON generation due to the following two PRs:
|
since we just bumped root version to 20.0.0-SNAPSHOT, we can try a code generation based on this PR to see if this is backward compatible. @brendandburns is there any other driver we want to refresh this JSON file generation? |
@yue9944882 there were changes in the But yes, let's give it a try. |
@brendandburns trying to pinpoint that incompatibility introduced. but it looks the last commit in the generator upstream was one year ago: so we're probably already using |
We've been previously locked on the https://github.com/kubernetes-client/gen/pull/247/files That PR was done in an effort to migrate to |
@brendandburns gotcha, as a follow-up of this. i will cherry-pick the two PRs onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @yue9944882