Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Katib] Update documentation for suggestion algorithms #3418

Merged

Conversation

tenzen-y
Copy link
Member

I updated documentation for suggestion algorithms.

  1. Add Optuna to the documentation for the grid search algorithm
  2. Remove Chocolate from all documentation

Part-of: kubeflow/katib#2058

/hold for kubeflow/katib#2071

/assign @kubeflow/wg-automl-leads

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @tenzen-y !
/lgtm
/assign @johnugeorge

@johnugeorge
Copy link
Member

@tenzen-y Can you rebase?

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the update-suggestion-algorithms branch from be87a19 to ae5293a Compare January 5, 2023 18:32
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 5, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 5, 2023

@andreyvelich @johnugeorge Thanks for the review!
I have rebased it.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 5, 2023

/hold cancel

@andreyvelich
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 5, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bcb867c into kubeflow:master Jan 5, 2023
@tenzen-y tenzen-y deleted the update-suggestion-algorithms branch January 5, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants