Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chocolate Suggestion Service #2058

Closed
3 tasks done
tenzen-y opened this issue Dec 11, 2022 · 6 comments
Closed
3 tasks done

Remove Chocolate Suggestion Service #2058

tenzen-y opened this issue Dec 11, 2022 · 6 comments

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Dec 11, 2022

/kind discussion

The final commitment of Chocolate was 4 years ago and the community seems to be inactive. So the framework can not work on Python 3.10 since some Python standard libraries are not working on Python 3.10 as shown below:

../../../../../opt/hostedtoolcache/Python/3.9.15/x64/lib/python3.9/site-packages/chocolate/conditional/thompson.py:1
/opt/hostedtoolcache/Python/3.9.15/x64/lib/python3.9/site-packages/chocolate/conditional/thompson.py:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
from collections import Sequence

../../../../../opt/hostedtoolcache/Python/3.9.15/x64/lib/python3.9/site-packages/chocolate/base.py:1
/opt/hostedtoolcache/Python/3.9.15/x64/lib/python3.9/site-packages/chocolate/base.py:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
from collections import Mapping, Sequence

IMO, we have the following 3 options to resolve an issue:

  1. Remove Chocolate Suggestion Service from katib between 1 and 2 releases.
  2. Continue to use Python 3.9 only for the Chocolate Suggestion Service.
  3. Fork or hold the Chocolate repository and then maintain the framework by katib community.

I would like to choose the first option since we can provide major Chocolate search algorithms by using other frameworks in the following after we remove that framework:

  • Grid Search -> Optuna
  • Random Search -> Hyperopt, Goptuna or Optuna
  • Bayesian optimization -> Scikit-Optimize
  • QuasiRandom -> None (We are not providing this by default)
  • MOCMAES -> None (We are not providing this by default)

@kubeflow/wg-automl-leads @anencore94 wdyt?


TODO for removing Chocolate Suggestion Service:


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@johnugeorge
Copy link
Member

Agree. Since chocolate is not supported, better to remove over time.

@anencore94
Copy link
Member

I agree with you too :)

@andreyvelich
Copy link
Member

Yes, I think we should remove Chocolate from our supported suggestions.

Do we have any knowledge which frameworks might support QuasiRandom and MOCMAES ?
We support sobol Quasirandom Sequence from Goptuna, do we know the differences ?

@tenzen-y
Copy link
Member Author

tenzen-y commented Dec 13, 2022

@andreyvelich

Do we have any knowledge which frameworks might support QuasiRandom and MOCMAES ?

I can not find any frameworks to support MOCMAES. For example, optuna provides CmaEsSample, although not to support Multi-Objective.

https://optuna.readthedocs.io/en/stable/reference/samplers/index.html#optuna-samplers

We support sobol Quasirandom Sequence from Goptuna, do we know the differences ?

Each framework seems to be different from the generator for quasi-random numbers.

/cc @c-bata

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 9, 2023

I created another issue, #2078, about MOCAMES.
/close

@google-oss-prow
Copy link

@tenzen-y: Closing this issue.

In response to this:

I created another issue, #2078, about MOCAMES.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants