Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intro tutorial updates #1240

Merged
merged 2 commits into from
Oct 16, 2019
Merged

intro tutorial updates #1240

merged 2 commits into from
Oct 16, 2019

Conversation

amygdala
Copy link
Contributor

@amygdala amygdala commented Oct 15, 2019

tracking issue: #1221 .
Accompanying update to the example code: kubeflow/examples#658 (pin the TF version in the web-ui dockerfile) .

My text editor trims EOL whitespace, so there are a bunch of diffs for those. The changes of substance:

  • changed the tf-serving service from mnist-gcs-dist to mnist-service so that the web UI would work out of the box. (If there is a good reason for using the other name, we can have them edit the service in the web ui, but they'll see that scary error first)
  • when they set up their bucket paths, add a timestamp-based subdir (so that they can run the example more than once)
  • since the web-ui service is using ClusterIP, and not generating an external IP, changed the instructions to have them port-forward. (I left some of the old stuff in but commented out -- feel free to ask me to just delete)
  • fixed some instructions on how to edit the gcr image in the web ui deployment.yaml file.

This change is Reviewable

@amygdala
Copy link
Contributor Author

/assign @sarahmaddox , + could you take a look as well, Dan? @dansanche

Copy link
Contributor

@sarahmaddox sarahmaddox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amy! Just a few comments from a tech writing point of view.

@sarahmaddox
Copy link
Contributor

/assign

@amygdala
Copy link
Contributor Author

PTAL again.

@sarahmaddox
Copy link
Contributor

Thanks @amygdala This looks great.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants