-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intro tutorial updates #1240
intro tutorial updates #1240
Conversation
/assign @sarahmaddox , + could you take a look as well, Dan? @dansanche |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Amy! Just a few comments from a tech writing point of view.
/assign |
PTAL again. |
Thanks @amygdala This looks great. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sarahmaddox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tracking issue: #1221 .
Accompanying update to the example code: kubeflow/examples#658 (pin the TF version in the web-ui dockerfile) .
My text editor trims EOL whitespace, so there are a bunch of diffs for those. The changes of substance:
mnist-gcs-dist
tomnist-service
so that the web UI would work out of the box. (If there is a good reason for using the other name, we can have them edit the service in the web ui, but they'll see that scary error first)ClusterIP
, and not generating an external IP, changed the instructions to have them port-forward. (I left some of the old stuff in but commented out -- feel free to ask me to just delete)deployment.yaml
file.This change is