-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin the web-ui version of TF to 1.7-- same as training #658
Conversation
/assign @dansanche |
@amygdala: GitHub didn't allow me to assign the following users: DanSanche. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I don't believe the test failure is related to my (very small) change. |
/retest |
@amygdala could you please show the errors? I'm curious why have import error since tensorflow should be compatible :-) |
@jinchihe It's |
Oh, understood, I remember |
ye, we need to take a look the ci tests. |
I wonder if we could just pull this in? 😬Don't know what is up w/ the tests, which I did not set up. |
@amygdala Seems the test problem is not caused by the code change, seems caused by test env problem. /retest |
Get some logs, need deep investigation.
|
@amygdala Try rebasing since some issues with tests have been resolved in master. |
great, will do. (this had popped off my stack 😬) |
Hmm, still no luck apparently. (I haven't dug in to the test details yet). |
/retest |
FINALLY the (unrelated) tests passed :) |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amygdala, zhenghuiwang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Newer versions give an import error.
This change is