Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin the web-ui version of TF to 1.7-- same as training #658

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

amygdala
Copy link
Collaborator

@amygdala amygdala commented Oct 12, 2019

Newer versions give an import error.


This change is Reviewable

@amygdala
Copy link
Collaborator Author

/assign @dansanche

@k8s-ci-robot
Copy link
Contributor

@amygdala: GitHub didn't allow me to assign the following users: DanSanche.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @dansanche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amygdala
Copy link
Collaborator Author

I don't believe the test failure is related to my (very small) change.

@jinchihe
Copy link
Member

/retest

@jinchihe
Copy link
Member

Newer versions give an import error.

@amygdala could you please show the errors? I'm curious why have import error since tensorflow should be compatible :-)

@amygdala
Copy link
Collaborator Author

@jinchihe It's
from tensorflow.examples.tutorials.mnist import input_data causing the problem, which at some point must have been removed (or moved?). The training Dockerfile.model uses FROM tensorflow/tensorflow:1.7.0 and so they should probably stay synced anyway.

@jinchihe
Copy link
Member

@jinchihe It's
from tensorflow.examples.tutorials.mnist import input_data causing the problem, which at some point must have been removed (or moved?). The training Dockerfile.model uses FROM tensorflow/tensorflow:1.7.0 and so they should probably stay synced anyway.

Oh, understood, I remember mnist is moved to somewhere :-) Thank you!

@jinchihe
Copy link
Member

ye, we need to take a look the ci tests.

@amygdala
Copy link
Collaborator Author

I wonder if we could just pull this in? 😬Don't know what is up w/ the tests, which I did not set up.

@jinchihe
Copy link
Member

@amygdala Seems the test problem is not caused by the code change, seems caused by test env problem.

/retest

@jinchihe
Copy link
Member

Get some logs, need deep investigation.

esting/util.py|42| Running: kustomize edit add configmap mnist-map-training --from-literal=secretMountPath=/var/secrets
cwd=/mnt/test-data-volume/kubeflow-examples-presubmit-mnist-658-e54ebb2-8672-22f7/src/kubeflow/examples/mnist/training/GCS
INFO|2019-10-23T01:04:47|/mnt/test-data-volume/kubeflow-examples-presubmit-mnist-658-e54ebb2-8672-22f7/src/kubeflow/testing/py/kubeflow/t
esting/util.py|57| Subprocess output:
error: SchemaError(io.k8s.api.certificates.v1beta1.CertificateSigningRequestList): invalid object doesn't have additional properties
ERROR|2019-10-23T01:04:49|/mnt/test-data-volume/kubeflow-examples-presubmit-mnist-658-e54ebb2-8672-22f7/src/kubeflow/tf-operator/py/kubef
low/tf_operator/test_runner.py|72| There was a problem running the job; Exception Command 'kustomize build /mnt/test-data-volume/kubeflow
-examples-presubmit-mnist-658-e54ebb2-8672-22f7/src/kubeflow/examples/mnist/training/GCS| kubectl apply -f -' returned non-zero exit stat
us 1
Traceback (most recent call last):
 File "/mnt/test-data-volume/kubeflow-examples-presubmit-mnist-658-e54ebb2-8672-22f7/src/kubeflow/tf-operator/py/kubeflow/tf_operator/tes
t_runner.py", line 53, in run_test
   test_func()
 File "tfjob_test.py", line 96, in test_train
   subprocess.check_call(subCmd, shell=True)
 File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
   raise CalledProcessError(retcode, cmd)
CalledProcessError: Command 'kustomize build /mnt/test-data-volume/kubeflow-examples-presubmit-mnist-658-e54ebb2-8672-22f7/src/kubeflow/e
xamples/mnist/training/GCS| kubectl apply -f -' returned non-zero exit status 1

@texasmichelle
Copy link
Member

@amygdala Try rebasing since some issues with tests have been resolved in master.

@amygdala
Copy link
Collaborator Author

amygdala commented Jan 7, 2020

great, will do. (this had popped off my stack 😬)

@amygdala
Copy link
Collaborator Author

amygdala commented Jan 7, 2020

Hmm, still no luck apparently. (I haven't dug in to the test details yet).

@amygdala
Copy link
Collaborator Author

/retest

@amygdala
Copy link
Collaborator Author

FINALLY the (unrelated) tests passed :)
@jinchihe or @texasmichelle , would you mind lgtm-ing/approving?

@zhenghuiwang
Copy link
Contributor

/lgtm
/approve

@amygdala
Copy link
Collaborator Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amygdala, zhenghuiwang
To complete the pull request process, please assign texasmichelle
You can assign the PR to them by writing /assign @texasmichelle in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amygdala amygdala merged commit 68f172c into kubeflow:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants