Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deploy model name conflict in case of concurrent notebook sample test #636

Merged
merged 2 commits into from
Jan 5, 2019
Merged

fix deploy model name conflict in case of concurrent notebook sample test #636

merged 2 commits into from
Jan 5, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jan 5, 2019

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 5, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ea72316 into kubeflow:master Jan 5, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* If we don't cleanup unmanaged certificates we will run out of ceritifacte
  quota (kubeflow#636).

* For unmanaged certificates we set a large expiration time (7 days).
  The only source for unmanaged certificates should be some tests
  which are still using self-signed certificates as a work around for lets
  encrypt quota issues. We should be able to stop using self signed certificates
  becaue managed certificates should no longer have those limits

Fix kubeflow#636
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* There is a bug in the SSL certificate cleanup code which is preventing
  certificates from being GC'd.

* Fix kubeflow#636
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants