-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deploy model name conflict in case of concurrent notebook sample test #636
fix deploy model name conflict in case of concurrent notebook sample test #636
Conversation
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* If we don't cleanup unmanaged certificates we will run out of ceritifacte quota (kubeflow#636). * For unmanaged certificates we set a large expiration time (7 days). The only source for unmanaged certificates should be some tests which are still using self-signed certificates as a work around for lets encrypt quota issues. We should be able to stop using self signed certificates becaue managed certificates should no longer have those limits Fix kubeflow#636
* There is a bug in the SSL certificate cleanup code which is preventing certificates from being GC'd. * Fix kubeflow#636
This change is