Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go vet in Travis tests breaks tests for unrelated PRs #646

Closed
Ark-kun opened this issue Jan 8, 2019 · 0 comments
Closed

go vet in Travis tests breaks tests for unrelated PRs #646

Ark-kun opened this issue Jan 8, 2019 · 0 comments
Assignees
@neuromage

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 8, 2019

This PR does not touch any Go code: #642

# github.com/kubeflow/pipelines/backend/src/crd/controller/viewer/reconciler
crd/controller/viewer/reconciler/reconciler.go:120: declaration of "err" shadows declaration at crd/controller/viewer/reconciler/reconciler.go:117
crd/controller/viewer/reconciler/reconciler.go:146: declaration of "err" shadows declaration at crd/controller/viewer/reconciler/reconciler.go:143
The command "go vet -all -shadow ./..." exited with 2.

Our Travis test setup has a problem - it only tests the branch code instead of the result of merging the branch into master. This can cause some integration errors to slip in and break the tests for everyone.

/assign @neuromage
@Ark-kun Ark-kun mentioned this issue Jan 8, 2019
Merged
@neuromage neuromage mentioned this issue Jan 8, 2019
Merged
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@jlewi
Remove applications.py; commonLabels should be immutable. (kubeflow#646)
021a975 
* See kubeflow/manifests#1131  we want commonLabels to be immutable
  otherwise upgrades won't work because we end up trying to change
  selectors which are immutable.

* The applications.py script inherently violates that because it was
  mutating commonLabels on every release. We don't want to do that
  anymore so we delete the script.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@ellistarn
Added licenses. (kubeflow#646)
4401841
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@ScrapCodes
Fix: go tests for pipelineLoop controller. (kubeflow#646)
3611c44 
* Fix: go tests for pipelineLoop controller.

* Skip adding timeout, if custom task.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@ScrapCodes
Proposal: Adding ScrapCodes as approver. (kubeflow#754)
3f13201 
Some of the recent PRs.

kubeflow#750 kubeflow#709 kubeflow#706 kubeflow#633 kubeflow#636 kubeflow#638 kubeflow#646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neuromage neuromage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neuromage @Ark-kun