Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serializing cloned embedded pipeline #474

Merged
merged 5 commits into from
Dec 5, 2018

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Dec 5, 2018

Follow up on #75. Embedded pipeline spec is actually JSON not YAML.


This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Dec 5, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 5, 2018

Does Argo sends it in JSON format? Or is it our backend?

@yebrahim
Copy link
Contributor Author

yebrahim commented Dec 5, 2018

It's our backend.

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 5, 2018

/lgtm

@yebrahim yebrahim merged commit 114a847 into kubeflow:master Dec 5, 2018
@yebrahim yebrahim deleted the clone-notebook-run branch December 5, 2018 05:33
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Parse the SSL certificates so that we get the associated domain.

  Use this to expire SSL certificates from pre/postsubmits after a couple
  hours while leaving the certificates for the auto deployments around longer.

* Minor fixes to some of the other tools.

Related to kubeflow#461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants