-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cloning run started from notebook #75
Comments
The UX ask here is what to display in the 'Pipeline' field when a run created from a Notebook is cloned? As there won't be a pipeline ID to show in the 'Pipeline' field? And when you say spec is passed, do you mean the pipeline definition in YAML? |
Yes, we need to show something in the stead of a pipeline ID, o perhaps the entire selector widget, while enabling the user to still switch back to the selector if they change their mind about cloning. The pipeline spec is whatever the pipeline definition is as stored by the backend, right now it's indeed a YAML spec. |
Spec for handling pipeline column in runs generated from Notebook. In the pipeline column, replace name with a link 'View pipeline' when a pipeline ID is not available. Selecting the link, takes the user to the pipeline details page with the app bar as show below. No actions to be displayed. We will reassess if actions are needed at a later point. Use 'Experiments > [run name]' breadcrumb to navigate back to the runs list. |
The breadcrumbs should show the run name too, not just the experiment name. This is very important I think, since it's the only usable identifier for this pipeline. |
If the user observed that the back button just does browser back, it won't be confusing at all. It'll take the user back to the previous page (list page), and the breadcrumbs are there in case the user wants to navigate to that run from the pipeline details page. |
Ok opt 1 sounds good. |
Sklearn server
* init code * add initial workspace workaround * added workspaces to pipelinerun * fix typo * only use workspace if necessary * add extra steps for copying non configurable output file path * update comment * update container image * update copy step to use busybox * update comments * replace workspaces with emptydir volume * revert workspace changes * fix volume edge case * update comments * update test report
Update owners.
Currently, runs have two ways of telling which pipeline was used to start them:
The UI should be passing that spec when cloning a run that does not have a pipeline id. We need to also figure out the UX, since a user might still be able to change their mind after starting a clone from a run, then want to switch to another pipeline.
@ajayalfred any thoughts here?
The text was updated successfully, but these errors were encountered: