Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline version support to frontend #2667

Merged
merged 13 commits into from
Dec 6, 2019
Merged

Add pipeline version support to frontend #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8e9f372
FE changes for version ui
jingzhang36 Dec 2, 2019
bfd7efd
sort methods; remove console
jingzhang36 Dec 2, 2019
5584a26
format
jingzhang36 Dec 2, 2019
23fbbfb
remove obsolete snapshots
jingzhang36 Dec 2, 2019
3777065
cosmetic change: simplify href link construction
jingzhang36 Dec 2, 2019
efb5453
fix the clone run behavior when version present
jingzhang36 Dec 2, 2019
7449a6f
format
jingzhang36 Dec 2, 2019
f67ee42
run-integration-test
jingzhang36 Dec 3, 2019
dc23b24
frontend-integration-test: try to simulate uploading file
jingzhang36 Dec 3, 2019
fe30a46
fix frontend-integration-test
jingzhang36 Dec 4, 2019
82d9947
Merge branch 'version_ui' of github.com:jingzhang36/pipelines into ve…
jingzhang36 Dec 4, 2019
6f71a74
address comments
jingzhang36 Dec 5, 2019
c9e7efb
address comments and add one more unit test
jingzhang36 Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 30 additions & 11 deletions frontend/server/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions frontend/src/components/CustomTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,7 @@ const BodyRowSelectionSection: React.FC<BodyRowSelectionSectionProps> = ({
expandState === ExpandState.EXPANDED && css.expandButtonExpanded,
)}
onClick={onExpand}
aria-label='Expand'
>
<ArrowRight />
</IconButton>
Expand Down
9 changes: 8 additions & 1 deletion frontend/src/components/Router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import Toolbar, { ToolbarProps } from './Toolbar';
import { Route, Switch, Redirect } from 'react-router-dom';
import { classes, stylesheet } from 'typestyle';
import { commonCss } from '../Css';
import NewPipelineVersion from '../pages/NewPipelineVersion';

export type RouteConfig = { path: string; Component: React.ComponentType<any>; view?: any };

Expand All @@ -58,6 +59,7 @@ export enum QUERY_PARAMS {
isRecurring = 'recurring',
firstRunInExperiment = 'firstRunInExperiment',
pipelineId = 'pipelineId',
pipelineVersionId = 'pipelineVersionId',
fromRunId = 'fromRun',
runlist = 'runlist',
view = 'view',
Expand All @@ -66,6 +68,7 @@ export enum QUERY_PARAMS {
export enum RouteParams {
experimentId = 'eid',
pipelineId = 'pid',
pipelineVersionId = 'vid',
runId = 'rid',
ARTIFACT_TYPE = 'artifactType',
EXECUTION_TYPE = 'executionType',
Expand All @@ -91,9 +94,11 @@ export const RoutePage = {
EXPERIMENTS: '/experiments',
EXPERIMENT_DETAILS: `/experiments/details/:${RouteParams.experimentId}`,
NEW_EXPERIMENT: '/experiments/new',
NEW_PIPELINE_VERSION: '/pipeline_versions/new',
NEW_RUN: '/runs/new',
PIPELINES: '/pipelines',
PIPELINE_DETAILS: `/pipelines/details/:${RouteParams.pipelineId}?`, // pipelineId is optional
PIPELINE_DETAILS: `/pipelines/details/:${RouteParams.pipelineId}/version/:${RouteParams.pipelineVersionId}?`,
PIPELINE_DETAILS_NO_VERSION: `/pipelines/details/:${RouteParams.pipelineId}?`, // pipelineId is optional
RECURRING_RUN: `/recurringrun/details/:${RouteParams.runId}`,
RUNS: '/runs',
RUN_DETAILS: `/runs/details/:${RouteParams.runId}`,
Expand Down Expand Up @@ -149,9 +154,11 @@ const Router: React.FC<RouterProps> = ({ configs }) => {
},
{ path: RoutePage.EXPERIMENT_DETAILS, Component: ExperimentDetails },
{ path: RoutePage.NEW_EXPERIMENT, Component: NewExperiment },
{ path: RoutePage.NEW_PIPELINE_VERSION, Component: NewPipelineVersion },
{ path: RoutePage.NEW_RUN, Component: NewRun },
{ path: RoutePage.PIPELINES, Component: PipelineList },
{ path: RoutePage.PIPELINE_DETAILS, Component: PipelineDetails },
{ path: RoutePage.PIPELINE_DETAILS_NO_VERSION, Component: PipelineDetails },
{ path: RoutePage.RUNS, Component: ExperimentsAndRuns, view: ExperimentsAndRunsTab.RUNS },
{ path: RoutePage.RECURRING_RUN, Component: RecurringRunDetails },
{ path: RoutePage.RUN_DETAILS, Component: RunDetails },
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/components/__snapshots__/CustomTable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ exports[`CustomTable renders a collapsed row 1`] = `
color="primary"
/>
<WithStyles(IconButton)
aria-label="Expand"
className="expandButton"
onClick={[Function]}
>
Expand Down Expand Up @@ -356,6 +357,7 @@ exports[`CustomTable renders a collapsed row when selection is disabled 1`] = `
className="cell selectionToggle"
>
<WithStyles(IconButton)
aria-label="Expand"
className="expandButton"
onClick={[Function]}
>
Expand Down Expand Up @@ -1055,6 +1057,7 @@ exports[`CustomTable renders an expanded row with expanded component below it 1`
color="primary"
/>
<WithStyles(IconButton)
aria-label="Expand"
className="expandButton expandButtonExpanded"
onClick={[Function]}
>
Expand Down
Loading