-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline version support to frontend #2667
Conversation
/assign @Bobgy preliminary review requested. Tests to be added. |
Test failed with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main structure looks good!
I put some nitpickings to hope improve readability.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
I re-ran "npm run format". But still see formatting complaints... |
6162c96
to
8e9f372
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/test kubeflow-pipeline-e2e-test |
Note setuptools is not a real failure, one integration test failed at the end of log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a thorough review and left some comments, mostly nitpicking. This is good!
I think we are close to merge once these are addressed (and integration test is fixed).
/test kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-sample-test |
/test kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-sample-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is