Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline version support to frontend #2667

Merged
merged 13 commits into from
Dec 6, 2019

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Nov 27, 2019

  1. NewPipelineVersion page for uploading pipeline and version (replacing old upload pipeline dialog)
  2. PipelineVersionList page for listing pipeline versions, e.g., when pipeline gets expanded in our home page
  3. RunList page shows version reference as well as pipeline reference. In particular, old runs (created before version is introduced) show pipeline reference, while new runs show version reference.
  4. Create run from versions instead of pipelines.
  5. Delete version button
  6. Clone run when run refers to version or refers to pipeline

This change is Reviewable

@jingzhang36
Copy link
Contributor Author

/assign @Bobgy preliminary review requested. Tests to be added.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 27, 2019

Test failed with

Checking formatting...
src/lib/Buttons.ts
src/lib/RunUtils.ts
src/pages/RunList.test.tsx
src/pages/RunList.tsx
Code style issues found in the above file(s). Forgot to run Prettier?

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main structure looks good!
I put some nitpickings to hope improve readability.

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jingzhang36
Copy link
Contributor Author

Test failed with

Checking formatting...
src/lib/Buttons.ts
src/lib/RunUtils.ts
src/pages/RunList.test.tsx
src/pages/RunList.tsx
Code style issues found in the above file(s). Forgot to run Prettier?

I re-ran "npm run format". But still see formatting complaints...

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@Bobgy
Copy link
Contributor

Bobgy commented Dec 2, 2019

Note setuptools is not a real failure, one integration test failed at the end of log.

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a thorough review and left some comments, mostly nitpicking. This is good!

I think we are close to merge once these are addressed (and integration test is fixed).

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@Bobgy Bobgy self-assigned this Dec 6, 2019
@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@jingzhang36
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@Bobgy
Copy link
Contributor

Bobgy commented Dec 6, 2019

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants