Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for filter.proto #2447

Merged
merged 2 commits into from
Oct 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/api/experiment.proto
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ message ListExperimentsRequest {
// Ascending by default.
string sort_by = 3;

// A base-64 encoded, JSON-serialized Filter protocol buffer (see
// A url-encoded, JSON-serialized Filter protocol buffer (see
// filter.proto).
string filter = 4;
}
Expand All @@ -118,7 +118,7 @@ message ListExperimentsResponse {
string next_page_token = 2;
}

message DeleteExperimentRequest{
message DeleteExperimentRequest {
// The ID of the experiment to be deleted.
string id = 1;
}
Expand All @@ -131,7 +131,7 @@ message Experiment {
string name = 2;

// Optional input field. Describing the purpose of the experiment
string description =3;
string description = 3;

// Output. The time that the experiment created.
google.protobuf.Timestamp created_at = 4;
Expand Down
647 changes: 584 additions & 63 deletions backend/api/go_client/pipeline.pb.go

Large diffs are not rendered by default.

64 changes: 34 additions & 30 deletions backend/api/go_client/resource_reference.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion backend/api/go_http_client/job_model/api_cron_schedule.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion backend/api/go_http_client/job_model/api_resource_type.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions backend/api/go_http_client/pipeline_model/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@ go_library(
name = "go_default_library",
srcs = [
"api_get_template_response.go",
"api_list_pipeline_versions_response.go",
"api_list_pipelines_response.go",
"api_parameter.go",
"api_pipeline.go",
"api_pipeline_version.go",
"api_relationship.go",
"api_resource_key.go",
"api_resource_reference.go",
"api_resource_type.go",
"api_status.go",
"api_url.go",
"protobuf_any.go",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions backend/api/go_http_client/pipeline_model/api_pipeline.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading