Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for filter.proto #2447

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Oct 21, 2019

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 23, 2019

This PR diff seems to be quite big.
Are you sure it only does what's in the PR title?

@neuromage
Copy link
Contributor Author

This PR diff seems to be quite big.
Are you sure it only does what's in the PR title?

If you change anything in the proto, you have to regenerate the relevant files.

@neuromage
Copy link
Contributor Author

/assign @IronPan

Fixes #2412

@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

I think the exploded size of the PR due to previous changes not regenerating the files.
/cc @jingzhang36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants