Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Notebooks - Deprecated the docker magic #2266

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 30, 2019

Fixes #2266

This change is Reviewable

Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c7b95dd into kubeflow:master Sep 30, 2019
@Ark-kun Ark-kun deleted the SDK---Notebooks---Deprecated-the-docker-magic branch October 1, 2019 17:09
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Fix incorrect function definition, issue kubeflow#2258

Signed-off-by: Eyal Cohen <eyalcohen@eyals-mbp.haifa.il.ibm.com>
Signed-off-by: Eyal Cohen <eyalcohen@sig-9-145-160-25.de.ibm.com>

* Fix lint - unused imported

Signed-off-by: Eyal Cohen <eyalcohen@sig-9-145-160-25.de.ibm.com>

Co-authored-by: Eyal Cohen <eyalcohen@eyals-mbp.haifa.il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants