Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to deprecate %%docker magic #1660

Closed
SinaChavoshi opened this issue Jul 24, 2019 · 2 comments
Closed

Request to deprecate %%docker magic #1660

SinaChavoshi opened this issue Jul 24, 2019 · 2 comments
Assignees
@Ark-kun
Labels
sdk/containers

Comments

@SinaChavoshi
Copy link
Contributor

Also closes #1547

This is a request to eliminate redundant methods of building docker / components. Specifically to remove %% docker magic wrapper.

This will ensure that

  1. methods of building docker and component are kept update as there are fewer of them to maintain.
  2. The path for building components and docker is clear ( less confusing ) by reducing the multiple ways that the same code can be written.
@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 24, 2019

Related: #1659

@Ark-kun Ark-kun self-assigned this Jul 25, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 12, 2019

Fixed by #2266

@Ark-kun Ark-kun closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
sdk/containers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ark-kun @SinaChavoshi