Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Containers - Build python container image based on current working directory #1970

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 28, 2019

Fixes #1688


This change is Reviewable

@Ark-kun Ark-kun force-pushed the SDK---Containers---Build-container-image-from-current-environment branch from 61321c3 to bafecb6 Compare August 28, 2019 18:31
@Ark-kun Ark-kun changed the title [WIP] SDK - Containers - Build container image from current environment SDK - Containers - Build container image from current environment Aug 28, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 28, 2019

/retest

@Ark-kun Ark-kun force-pushed the SDK---Containers---Build-container-image-from-current-environment branch from bafecb6 to 22e3c9f Compare August 28, 2019 20:47
@Ark-kun Ark-kun changed the title SDK - Containers - Build container image from current environment SDK - Containers - Build container image from current working directory Sep 3, 2019
@Ark-kun Ark-kun changed the title SDK - Containers - Build container image from current working directory SDK - Containers - Build python container image based on current working directory Sep 3, 2019
Ark-kun and others added 6 commits September 3, 2019 18:43
`kfp.containers.default_base_image = ...`
The image can also be a callable returning the image name.
…ge as requested by @hongye-sun

The size of this image is 4.35GB which really concerns me. The GPU image size is 6.45GB.
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 4, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 4, 2019

/retest

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 4, 2019

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 4, 2019

/retest

@hongye-sun
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 6, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 08104d6 into kubeflow:master Sep 6, 2019
@Ark-kun Ark-kun deleted the SDK---Containers---Build-container-image-from-current-environment branch September 6, 2019 22:27
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* annotations
* appended
* arbitrary
* architecture
* archive
* associated
* builtin
* character
* classification
* container
* control
* credentials
* downloader
* egress
* entities
* explain
* explanation
* forwarding
* grafana
* heuristic
* huggingface
* identified
* image
* include
* instances
* interpreting
* knative
* kubernetes
* licenses
* lightgbm
* module
* overridden
* patched
* pmmlserver
* prediction
* predictions
* prerequisites
* previous
* provides
* queries
* reconcile
* request
* resource
* specified
* storage
* tabular
* tokenization
* transformer
* transition
* true
* unknown
* variabilize
* workflows
* wrapper

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to build container image with the same packages as the current environment.
4 participants