We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened:
Currently kfp compiler can not use a docker context as a directory, see the code link
with tempfile.TemporaryDirectory() as local_build_dir: dockerfile_rel_path = 'Dockerfile' dst_dockerfile_path = os.path.join(local_build_dir, dockerfile_rel_path) shutil.copyfile(dockerfile_path, dst_dockerfile_path)
What did you expect to happen: I think it is good to support a docker context instead of just a relational path to a Dockerfile.
What steps did you take: Here is my example of code:
import os from kfp import compiler os.environ["GOOGLE_CLOUD_PROJECT"] = "my-project" os.environ["GOOGLE_APPLICATION_CREDENTIALS"] = "gcp.json" build = compiler.build_docker_image( staging_gcs_path="gs://kfp-build-stage", target_image="gcr.io/mmy-project/kfp-build", dockerfile_path="/kubeflow_pipelines/docker_build/src/Dockerfile", timeout=600, namespace="kubeflow" )
As a result, I can not build a docker image that requires a docker context.
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]
Will submit a pull request.
The text was updated successfully, but these errors were encountered:
Pull request https://github.com/pahask8/pipelines/pull/new/2014
Sorry, something went wrong.
Could someone please take a look at #2015 ? Thank you
Fixed by #1970
Supports more authentication approaches on Azure in Storage Initializ…
f8c0699
…er (kubeflow#2014) * Use DefaultAzureCredential to support multiple authentication Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Use environment variables that matches Azure Identity SDK Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Fix test case failure Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Add documentation to Azure Managed Identity Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Use new key for SA secret entries Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> * Correct Kubernetes manifest in Azure storage sample Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com> Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Ark-kun
No branches or pull requests
What happened:
Currently kfp compiler can not use a docker context as a directory, see the code link
What did you expect to happen:
I think it is good to support a docker context instead of just a relational path to a Dockerfile.
What steps did you take:
Here is my example of code:
As a result, I can not build a docker image that requires a docker context.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Will submit a pull request.
The text was updated successfully, but these errors were encountered: