Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfp compiler can not use a docker context as a directory #2014

Closed
pahask8 opened this issue Aug 30, 2019 · 3 comments
Closed

kfp compiler can not use a docker context as a directory #2014

pahask8 opened this issue Aug 30, 2019 · 3 comments
Assignees

Comments

@pahask8
Copy link
Contributor

pahask8 commented Aug 30, 2019

What happened:

Currently kfp compiler can not use a docker context as a directory, see the code link

with tempfile.TemporaryDirectory() as local_build_dir:
    dockerfile_rel_path = 'Dockerfile'
    dst_dockerfile_path = os.path.join(local_build_dir, dockerfile_rel_path)
    shutil.copyfile(dockerfile_path, dst_dockerfile_path)

What did you expect to happen:
I think it is good to support a docker context instead of just a relational path to a Dockerfile.

What steps did you take:
Here is my example of code:

import os
from kfp import compiler

os.environ["GOOGLE_CLOUD_PROJECT"] = "my-project"
os.environ["GOOGLE_APPLICATION_CREDENTIALS"] = "gcp.json"

build = compiler.build_docker_image(
    staging_gcs_path="gs://kfp-build-stage",
    target_image="gcr.io/mmy-project/kfp-build",
    dockerfile_path="/kubeflow_pipelines/docker_build/src/Dockerfile",
    timeout=600,
    namespace="kubeflow"
)

As a result, I can not build a docker image that requires a docker context.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Will submit a pull request.

@pahask8
Copy link
Contributor Author

pahask8 commented Aug 30, 2019

@Ark-kun Ark-kun self-assigned this Sep 5, 2019
@pahask8
Copy link
Contributor Author

pahask8 commented Sep 9, 2019

Could someone please take a look at #2015 ? Thank you

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 3, 2019

Fixed by #1970

@Ark-kun Ark-kun closed this as completed Oct 3, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
…er (kubeflow#2014)

* Use DefaultAzureCredential to support multiple authentication

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

* Use environment variables that matches Azure Identity SDK

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

* Fix test case failure

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

* Add documentation to Azure Managed Identity

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

* Use new key for SA secret entries

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

* Correct Kubernetes manifest in Azure storage sample

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants