Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Compiler - Deprecated dsl-compile --package #1941

Merged
merged 2 commits into from
Aug 28, 2019
Merged

SDK - Compiler - Deprecated dsl-compile --package #1941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de78b83
SDK - Compiler - Deprecated dsl-compile --package
Ark-kun Aug 23, 2019
aa7c1d9
Switched to the Deprecated library
Ark-kun Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdk/python/kfp/compiler/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import subprocess
import sys
import tempfile
from deprecated.sphinx import deprecated


def parse_arguments():
Expand Down Expand Up @@ -84,6 +85,11 @@ def __exit__(self, *args):
dsl._pipeline._pipeline_decorator_handler = self.old_handler


@deprecated(version='0.1.28', reason='''\
The ability to compile pipeline from a python package is deprecated and will be removed in next release.
Please switch to compiling pipeline files or functions.
If you use this feature please create an issue in https://github.com/kubeflow/pipelines/issues .'''
)
def compile_package(package_path, namespace, function_name, output_path, type_check):
tmpdir = tempfile.mkdtemp()
sys.path.insert(0, tmpdir)
Expand Down
1 change: 1 addition & 0 deletions sdk/python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ argo-models == 2.2.1a
jsonschema >= 3.0.1
tabulate == 0.8.3
click == 7.0
Deprecated
3 changes: 2 additions & 1 deletion sdk/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
'argo-models == 2.2.1a', #2.2.1a is equivalent to argo 2.2.1
'jsonschema >= 3.0.1',
'tabulate == 0.8.3',
'click == 7.0'
'click == 7.0',
'Deprecated',
]

setup(
Expand Down